Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to UTF-8 mime type for actix-web and gotham #219

Closed
wants to merge 1 commit into from

Conversation

spease
Copy link
Contributor

@spease spease commented Mar 10, 2019

Fixes issue #209 for actix-web and gotham. Rocket uses its own internal Content function, so I left it alone. Also fixed the tests in askama_testing, which are what I used to validate the change.

NB I had to use if statements instead of match due to limitations of the mime type. I don't know why they're there.

@djc
Copy link
Owner

djc commented Mar 18, 2019

Thanks for fixing this! I got rid of the big if-table in favor of a const array, fixed the formatting and a new test that had appeared since you branched off, and pushed the result as d1b47f8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants